Skip to content

chore(*): build system improvements #9288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(*): build system improvements #9288

wants to merge 3 commits into from

Conversation

@hntrl
Copy link
Member

@hntrl hntrl commented Oct 29, 2025

  • use tsdown cli/configuration scheme instead of internal options
  • make tsdown plugins individually addressable
  • adds a barrel-dts plugin to fix some compatibility issues with commonjs dependants
  • changes build scripts in each package

Fixes #9252
Fixes #9268

@hntrl
chore(*): build system improvements
c91781a 
* use tsdown cli/configuration scheme instead of internal options
* make tsdown plugins individually addressable
* adds a barrel-dts plugin to fix some compatibility issues with commonjs dependants
* changes build scripts in each package

Fixes #9252
Fixes #9268
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e748cf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@langchain/azure-dynamic-sessions Patch
@langchain/google-cloud-sql-pg Patch
@langchain/google-vertexai-web Patch
@langchain/google-vertexai Patch
@langchain/azure-cosmosdb Patch
@langchain/google-webauth Patch
@langchain/baidu-qianfan Patch
@langchain/google-common Patch
@langchain/mixedbread-ai Patch
@langchain/google-gauth Patch
@langchain/google-genai Patch
@langchain/cloudflare Patch
@langchain/anthropic Patch
@langchain/mistralai Patch
@langchain/cerebras Patch
@langchain/deepseek Patch
@langchain/pinecone Patch
@langchain/weaviate Patch
@langchain/mongodb Patch
@langchain/cohere Patch
@langchain/ollama Patch
@langchain/openai Patch
@langchain/qdrant Patch
@langchain/tavily Patch
@langchain/yandex Patch
@langchain/nomic Patch
@langchain/redis Patch
@langchain/standard-tests Patch
@langchain/groq Patch
@langchain/textsplitters Patch
@langchain/aws Patch
@langchain/exa Patch
@langchain/xai Patch
@langchain/mcp-adapters Patch
@langchain/community Patch
@langchain/classic Patch
@langchain/core Patch
@langchain/eslint Patch
@langchain/build Patch
langchain Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 29, 2025
View reviewed changes
christian-bromann
christian-bromann reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are revisiting this: the idea of defining entry points via src property in exports of package.json I think made sense when we defined all build configs within @langchain/build. Now that we go back to workspace config files we could also define entry points there, e.g. as getBuildConfig parameter?

I don't see anything wrong with the current approach, except it is not standard conferment and vitest gets confused by this. What are your thoughts here?

@hntrl
Copy link
Member Author

hntrl commented Oct 30, 2025

As we are revisiting this: the idea of defining entry points via src property in exports of package.json I think made sense when we defined all build configs within

Could you elaborate more on this? Do you mean we should be changing how the entry config option is populated? I saw that tsdown has an exports key that may be of interest:
https://tsdown.dev/reference/api/Interface.UserConfig#exports

@christian-bromann
Copy link
Member

christian-bromann commented Oct 30, 2025

Currently package entries are defines within exports of package.json via input key, e.g.:

"./callbacks/base": {
  "input": "./src/callbacks/base.ts",
  "require": {
    "types": "./dist/callbacks/base.d.cts",
    "default": "./dist/callbacks/base.cjs"
  },
  "import": {
    "types": "./dist/callbacks/base.d.ts",
    "default": "./dist/callbacks/base.js"
  }
},

This is not standard conferment and other tools may get thrown off by this. Using this exports function would be great, can we give this a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@hntrl @christian-bromann